search

widmogrod / zf2-assetic-module

Zend Framework module for Assetic
146 stars 62 forks source link

Update deprecated packages, allow symfony/console ^5.0 #190

Closed tadasauciunas closed 3 years ago

tadasauciunas commented 3 years ago

The change removes deprecated kriswallsmith/assetic dependency, starts using assetic/framework (https://github.com/assetic-php/assetic). Also allows newest symfony/console and fabpot/php-cs-fixer library versions. The only place where symfony console was used was the CLI commands, so the 'return 0;' exit code change seems to have been the only change that was necessary with newest symfony versions. This fixes https://github.com/widmogrod/zf2-assetic-module/issues/187

tadasauciunas commented 3 years ago

Main purpose of this PR was to allow newest versions of symfony/console usage. Managed to get the travis builds running by upgrading the php, phpunit, phpcs fixer, other library versions. Let me know what you think @widmogrod

widmogrod commented 3 years ago

Hi @tadasauciunas, this is grate!

I and community will really appreciate this, especially that I no longer actively maintain this repository but I know that few people do.

Thank you, grate job!

Since this is breaking change I release this change under version 3.0.0

tadasauciunas commented 3 years ago

Do you need any help with releasing the 3.0.0 version ? @widmogrod

widmogrod commented 3 years ago

Hi @tadasauciunas it's released: https://packagist.org/packages/widmogrod/zf2-assetic-module#3.0.0 https://github.com/widmogrod/zf2-assetic-module/tree/3.0.0

tadasauciunas commented 3 years ago

Sorry, main github repository page didn't show it for some reason, my mistake :) Thanks