search

widop / WidopHttpAdapterBundle

Issue HTTP requests for your Symfony2 project.
MIT License
8 stars 13 forks source link

Added PHP 5.6 and HHVM to travis.yml #18

Open Nyholm opened 10 years ago

Nyholm commented 10 years ago

I did aslo fix the build matrix

egeloen commented 10 years ago

Can you update your PR in order to match this change? https://github.com/egeloen/IvoryLuceneSearchBundle/commit/29acad2c704d6016418ad8e6705b20ef896ab868 Basically, I would like to be sure everything will work with all Symfony/PHP versions combined. Additionally, you need to update the require composer command in order to be able to install the Symfony master version

Nyholm commented 10 years ago

That change you are referring to is not preferable. It will just create a awful lots of builds and they are redundant. You want to test this bundle agains multiple PHP versions. You do also want to test this bundle against multiple Symfony versions. The combination is not interesting because the integration will not differ between PHP versions. You have to trust the Symfony core guys to run their test suite in different PHP environments. (And they do)

I've updated the composer command as you recommended.