search

wiedehopf / readsb

ADS-B decoder swiss knife
Other
321 stars 70 forks source link

GCC unroll is a GCC 8 feature, not a GCC 7 one #28

Closed NoseyNick closed 1 year ago

NoseyNick commented 1 year ago

It appears GCC 8 introduced _Pragma ("GCC unroll N") not GCC 7. Ref: https://gcc.gnu.org/gcc-8/changes.html

A new pragma GCC unroll has been implemented in the C family of languages [...]

diff --git a/readsb.h b/readsb.h
index 994abf7..0ca42bc 100644
--- a/readsb.h
+++ b/readsb.h
@@ -357,7 +357,7 @@ typedef enum {

 #elif defined(__GNUC__)

-#if __GNUC__ >= 7
+#if __GNUC__ > 7
 #define _unroll_8 _Pragma ("GCC unroll 8")
 #define _unroll_16 _Pragma ("GCC unroll 16")
 #define _unroll_32 _Pragma ("GCC unroll 32")

LMK if you need this one-char fix in a PR :laughing:

Many thanks! Hope my next contribution will be a bigger one :see_no_evil:

NoseyNick commented 1 year ago

For history, see also #22, c10b73b47bd0f57c40ed93a5018aab3b3b1d89c2, and 705816bc54747d7fa8212fa66dc4e819204d655e, possibly b67e980a748266c7626c3d8e03d0d147bd7efcaa