search

wiedehopf / tar1090

Provides an improved webinterface for use with ADS-B decoders readsb / dump1090-fa
Other
1.25k stars 235 forks source link

Add a setting to persist filters to local storage. #152

Closed lart2150 closed 2 years ago

lart2150 commented 2 years ago

This will add a setting (disabled by default) to persist the filters to local storage.

This should resolve #14

I tested with all tracks enabled and then enabled a filter and it cleared all non selected plans that don't match.

wiedehopf commented 2 years ago

So this needs big fat warnings on load that the old filters have been restored or this produces tons of bug reports. Yes even if the setting is disabled by default.

Honestly having the filters encoded in the URL might be less of a support issue and more useful as people can bookmark various filter combinations.

Could you make a warning with two buttons "Disable Filters" and "Hide this" or along those lines that shows in the main map area?

On a whole other topic: It would be great to have the html for the aircraft details on the left generated somehow. Or something along those lines so it's easy to have a secondary two row (current single row) display of the aircraft details that could fill the lower area of a smartphone. Presenting the picture and some info side by side. Just if you're looking for something to work on.

lart2150 commented 2 years ago

What if the checkbox is "include filters in share link". I would then likely break out each filter into separate parameter.

wiedehopf commented 2 years ago

Yeah that would certainly work well!

lart2150 commented 2 years ago

I updated the PR to add the filters as get params and changed the setting to add the params to the share link but not the address bar.

sxdjt commented 2 years ago

Nice!! Thank you.