search

wiedehopf / tar1090

Provides an improved webinterface for use with ADS-B decoders readsb / dump1090-fa
Other
1.27k stars 237 forks source link

Speed is not displayed (dump1090-mutability) #195

Closed skaringa closed 2 years ago

skaringa commented 2 years ago

I run tar1090 with dump1090-mutability and I have to apply this patch to show the speed in the airplane labels and the table on the right. This is related to the fix you've done for #111, but in my opinion this fix was incomplete.

wiedehopf commented 2 years ago

https://github.com/wiedehopf/tar1090/commit/aad646dd430fe530d889f2588c58d3a071147d40

should be fixed. this PR wasn't the right thing to do.

wiedehopf commented 2 years ago

Also really, don't use dump1090-mutability. https://github.com/wiedehopf/adsb-scripts/wiki/Automatic-installation-for-readsb

skaringa commented 2 years ago

should be fixed. this PR wasn't the right thing to do.

I don't understand. It is definitely not fixed without my patch. And why is a PR not the right thing to provide patches? What would be the right thing?

wiedehopf commented 2 years ago

I pushed a commit which is linked.

Cleaned up the entire logic instead of making the change you proposed. That's at the discretion of the maintainer.

wiedehopf commented 2 years ago

Feel free to let me know if my commit didn't fix the issue.