search

wiedehopf / tar1090

Provides an improved webinterface for use with ADS-B decoders readsb / dump1090-fa
Other
1.21k stars 222 forks source link

improve CORS security #262

Closed dirkhh closed 10 months ago

dirkhh commented 10 months ago

Instead of creating a wildcard access control allow origin, limit it to the route api server.

Change requested by Ramon (@kx1t)

dirkhh commented 10 months ago

I would suggest not merging this until @kx1t agrees that this is what he's looking for. I did test it (will wonders never cease) and it seems to work, but I'd be lying if I claimed that I fully understand how all this is supposed to work... I mean... I start a request TO adsb.lol and tell them that I'm ok with adsb.lol? I mean... what?

dirkhh commented 10 months ago

The branch name is now completely bogus, but this should still address the concern that @kx1t voiced to me. The wildcard header is now simply gone.

iakat commented 10 months ago

(also this has no impact to security as the client is not the authority on CORS, the server is, so the request header did/does/will always do nothing)