Smoothen the interface - Githubissues

wiederm / endstate_correction

Endstate corrections from MM to QML potential

https://wiederm.github.io/endstate_correction/

MIT License

10 stars 1 forks source link

Smoothen the interface #59

Closed xiki-tempula closed 1 year ago

xiki-tempula commented 1 year ago

Description

I'm going to call endstate correction from asfe. This PR, I will try to smooth the interface to make it easier to be called and easier to read.

I'm changing the protocol.lam from pd.series to float and it makes things easier.

Todos

Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

codecov-commenter commented 1 year ago

Codecov Report

Merging #59 (65efe32) into main (32ba18f) will not change coverage. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

xiki-tempula commented 1 year ago

@wiederm Initially, I thought that I need a more complex interface, now I think a float is enough for this purpose.