Booking comments are not displayed anywhere - Githubissues

wielebenwir / cb-legacy

Wordpress plugin for managing and booking of common goods. New Version 2: https://github.com/wielebenwir/commonsbooking

http://www.wielebenwir.de/projekte/commons-booking

GNU General Public License v2.0

22 stars 12 forks source link

Booking comments are not displayed anywhere #122

Closed flegfleg closed 7 years ago

flegfleg commented 8 years ago

Originally reported by: Ralph W (Bitbucket: ralphW, GitHub: ralphW)

I have enabled all flags and released all booking comments, but can still not find them anywhere. Looks like a bug to me. Otherwise, please prove me wrong :)

System: test.klara.bike Version: 0.8.0.x

Bitbucket: https://bitbucket.org/wielebenwir/commons-booking/issue/122

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

Nils: sind Aktualisierungen für die Übersetzung verfügbar? Dashboard->Aktualisierungen

flegfleg commented 8 years ago

Original comment by Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk):

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

Mehr Infos? Welche Texte? Screenshots?

Muss ja vielleicht keine 'vollständige' Liste werden.

flegfleg commented 8 years ago

Original comment by Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk):

Ja, mit 0.8.0.9 funktioniert es! Nach der Aktualisierung sind aber plötzlich einige Commons-Booking-Texte auf Englisch, andere auf Deutsch. Davor war alles auf Deutsch.

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

fixed in 0.8.0.9

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

Yes, we do use a prefix that is not equals "wp_" but does contain an underscore.

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

fuckit. underscores & sql statements.

Kannst du bestätigen, dass ihr einen wpdb-präfix habt, der nicht "wp_" ist?

immer noch der selbe Fehler, ich denke jetzt hab ich´s aber ich schau´s mir morgen noch mal in ruhe an, bevor ich mit falscher ziuversicht nerve.

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

Is the fix part of commons-booking-08-beta3-0808.zip?

Unfortunately I still can not see any comments. They are also still auto-approved.

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

FIX: Issue #122: Now using correct DB Prefix so booking comments are accessed.

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

FIX: Issue #122: Now using correct DB Prefix so booking comments are accessed.

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

Hey Ralph, sorry.

Error is known, fix is coming soon.

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

With 0.8.0.7 I still can not see the comments, but the comments are auto-released. Is this wanted behaviour? Or should the always wait for moderation/release by an admin?

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

Ok, I saw the feature now on http://commons-booking-demo.wielebenwir.de/cb-items/kasimir/

Text suggestion: How about "Your comment will be displayed in the calendar to show people what %Itemname% is used for."

From my point of view there is another textual problem. "Gebucht von einem Benutzer: xxx" could look become something like "Gebucht von einem Benutzer: Sperrmüll"

How about we remove the "von einem Benutzer"?

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

In addition to that I think the communication towards the user should be made clearer

agreed. i´m open for text proposals ;)

On my setup, the correct name of the table seems to be d02218b8.69pSW_cb_bookings.

that´s it. will fix in the next release.

flegfleg commented 8 years ago

Original comment by Ralph W (Bitbucket: ralphW, GitHub: ralphW):

In addition to that I think the communication towards the user should be made clearer: what are these comments? Are they for the user? For the operator? Are they displayed to public? What should a user write?

flegfleg commented 8 years ago

Original comment by Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk):

I experience the same with version 0.8.0.6. fleg asked me to switch on Wordpress Debug mode. Then I get this error messag:

#!

WordPress-Datenbank-Fehler: [Table 'd02218b8.wp_cb_bookings' doesn't exist]
SELECT wp_cb_bookings.hash, comment_content FROM wp_cb_bookings INNER JOIN wp_commentmeta ON wp_commentmeta.meta_value=wp_cb_bookings.hash INNER JOIN wp_comments ON wp_comments.comment_ID= wp_commentmeta.comment_id WHERE comment_approved = 1 AND item_id = '9'

On my setup, the correct name of the table seems to be d02218b8.69pSW_cb_bookings.