Only one booking code in confirmation e-mail for booking > 1 day - Githubissues

wielebenwir / cb-legacy

Wordpress plugin for managing and booking of common goods. New Version 2: https://github.com/wielebenwir/commonsbooking

http://www.wielebenwir.de/projekte/commons-booking

GNU General Public License v2.0

22 stars 12 forks source link

Only one booking code in confirmation e-mail for booking > 1 day #135

Open flegfleg opened 8 years ago

flegfleg commented 8 years ago

Originally reported by: Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk)

Is this a bug? When I book an article for more than one day, I get a confirmation with the booking code of the first day only. How can I prove that I booked more than one day? I would need to show the printed confirmation email, which could be faked.

Wouldn't it be better to give booking codes of every booked day in the email?

Bitbucket: https://bitbucket.org/wielebenwir/commons-booking/issue/135

flegfleg commented 8 years ago

Original comment by Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk):

Ok, I'm satisfied. Thanks a lot (-;

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

Short answer: Yes, we trust the user.

Long answer: When we started, we had long discussions about this issue, gps tracking, deposits, accreditation, etc. But somebody with bad/criminal intentions WILL find ways to run off with the bike anyway. So we decided to keep it as simple as possible.

flegfleg commented 8 years ago

Original comment by Nils Larsen (Bitbucket: nillerdk, GitHub: nillerdk):

OK, do you require the users to show the confirmation e-mail when picking up the bike? Or do you just trust the user we he/she says: I booked the bike not only today, but also tomorrow. "Today" he can prove with the code, but I believe that there is no way for the bike station to verify "tomorrow".

flegfleg commented 8 years ago

Original comment by Florian Egermann (Bitbucket: flegfleg, GitHub: flegfleg):

Hi Nils, this is by design. Just one code makes it easier for both the user and the station. We use this system for 3 years with (currently) more 4 bikes. Happy to discuss any ideas/proposals, though. Best

Konafets commented 5 years ago

@flegfleg I would like to reopen this issue since we (our stations) asked the same question. Its not about the criminal intend you described but more the fact that any user can just claim the bike for two days without any proof. The station has to trust him not matter what. What happens another user shows up the next day with the correct code but the bike is lent to the user who claimed it for two days?

flegfleg commented 5 years ago

Hi Stefan,

that's true, it could fail. We designed our sharing system (and therefore, the software) this way, but of course that's the only possibility :)

Could you outline how you'd like to "verify" users and bookings? We are working on CommonsBooking 2, we can think about implementing other workflows.

Best!

Konafets commented 5 years ago

In our case the project is supported by the city for two years. I generated the codes for this time period for all stations (3) and gave them the codes as PDF.

Booking one day:

I book a bike for one day
I receive an email with the passphrase for that day.
I go to the station and tell them the passphrase. They look it up on the PDF.
If this matches, I get the bike.

Booking two days:

I book a bike for two day
I receive an email with the passphrase for the first of the two days
I go to the station and tell them I booked two days but can only provide one passphrase. They look it up on the PDF and see it does match with "today" but they have no information about if someone else booked the bike for the next day.

The simplest solution would be, that the codes for all booked days appears on the booking confirmation email.

flegfleg commented 5 years ago

Hi, the CB1.0 database structure just supports 1 code per booking, unfortunately. This will be different in CB2.0.

flegfleg commented 5 years ago

on second thought: you could still get the code for all days from the database, you would have to hack the plugin a lot, though.