search

wieni / mercure

A Drupal 8 & 9 module integrating the Mercure Component.
GNU General Public License v2.0
0 stars 1 forks source link

Drupal coding standards #3

Closed a-mawlawi closed 2 years ago

a-mawlawi commented 2 years ago

Thank you for this awesome module.

I really respect your own coding standards, but as this is a Drupal module we should go with Drupal coding standards without the need to run coding-standards script via composer and include the dev plugins.

If you are welcoming this, I will be happy to create a pull request for this.

Regards,

RobinHoutevelts commented 2 years ago

Not our own coding standard. But PSR-12 like almost any other PHP project.

Although I respect Drupal's coding standard. Drupal should use PSR-12

a-mawlawi commented 2 years ago

No need to create a pull request then, Thanks for saving my time.

RobinHoutevelts commented 2 years ago

@a-mawlawi you'll be happy to know I changed my mind and moved the project over to https://www.drupal.org/project/mercure where @DieterHolvoet is co-maintainer 🥳

The code style has already changed. However if, by now, you have any other contributions/issues you would like to share, please do!

The preferred channel is https://www.drupal.org/project/issues/mercure

I apologise for closing this issue earlier.