search

wierkstudio / ciphereditor

Web app for cryptography, coding and data encouraging beginners and pros alike to explore new operations and build own workflows.
https://ciphereditor.com
MIT License
115 stars 22 forks source link

Features: dropping modals #12

Closed robigan closed 2 years ago

robigan commented 2 years ago

Adds categories to the infamous AddModalView. So understanding what every option does is easier to understand.

Also addresses the issue that often, the AddModalView is expected to be larger than available screen size, so cap it's maximum height to 65vh. To be reviewed with @ffraenz

robigan commented 2 years ago

I just realized I need to rebase my PR branch onto upstream/dev

ffraenz commented 2 years ago

The design of the add modal is not finalized, yet. I envision it to be similar to an app/extension store as the library will be opend up for third-party developers eventually. The status quo is just a draft providing access to the core functionality.

I'd like to prepare the design in Figma first, before implementing it. I'm sorry for the work you've put in. Let's discuss design-related issues first, before heading to implementation to make sure your work will make it into the product.