search

wifimedia / robin-dash

Automatically exported from code.google.com/p/robin-dash
0 stars 0 forks source link

Nodog bandwidth controls not working correctly #29

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. On Public Network, set Download/Upload speeds to decimals
2. Tab between fields.  
3. Save settings

What is the expected output? What do you see instead?
Expect that web controls keep exactly the number I set (0.8 download and 0.3 
upload) and that a node will get these settings and apply them. >ndsctl status 
should show the corresponding limits.

Actual result: 
After setting the controls to any decimal value (for example 0.8 download and 
0.3 upload), the node gets set with the default 'unlimited' bandwidth: 
Result of ndsctl status:
Traffic control: yes
Download rate limit: 22528 kbit/s
Upload rate limit: 11264 kbit/s

this happens regardless of web browser. It appears to be a problem in how 
robin-dash stores and transmits information to the node.  Setting whole number 
values works to correctly update nodogsplash 

Also, using Firefox 4 in robin-dash, the Upload control field doesn't work as 
expected.  Setting values 0.3 or 0.4 and tabbing to the next field will change 
the upload value ot '0.1'.   setting the upload value to 0.5 and tabbing to 
next field changes the upload value to '1'.  This behavior doesn't happen in 
Chrome.

What version of the product are you using? On what operating system?
Hosted version. Chrome 10. Firefox 4.0 Windows XP.

Please provide any additional information below, such as the network name,
and the Server URL (If not using the Hosted Version)

Original issue reported on code.google.com by RobGM...@gmail.com on 4 Apr 2011 at 5:05

GoogleCodeExporter commented 8 years ago 
Slider issues are fixed and at least I can enter a decimal (0.8 and 0.3) and 
those values stick.
However, when updating a node with a decimal rate limit, nodogsplash still gets 
configured to the max download rate.

Original comment by RobGM...@gmail.com on 13 Apr 2011 at 3:55

GoogleCodeExporter commented 8 years ago 
Yes, it would appear that (for now at least) we wont be able to support 
decimals, this is due to a bug in the way that PHP is interpreting the 
variables.

Original comment by c...@codycooper.co.nz on 14 Apr 2011 at 11:11

GoogleCodeExporter commented 8 years ago 
Why not just switch to Kilobits, which is how it's supported (natively) in 
Nodogsplash?

Original comment by RobGM...@gmail.com on 14 Apr 2011 at 3:19