Closed jAniceto closed 3 years ago
Thanks again for contributing. I'll try to give you some feedback by Friday.
The only thing I noticed is for the axial_dispersion_coeff()
functio. The Dax
needs to be D_{ax}
in the docstring.
Thanks for the quick feedback and good catch on that. Just fixed it.
Is it D{ax}
or D_{ax}
with an underscore?
Should be with the underscore. Sorry about that. Can't fix it today but I'll correct it tomorrow.
Ok. I think it's all good now.
For the mass transfer functions that you added, are some of the functions specific to packed beds? If they only apply to packed beds then please make a note of that in the docstring for the relevant functions.
Yeah, for all but the molecular_diffusion_coeff
function, the way the equations are written is for packed beds. I just added a note to the docstrings.
Additions to the
dimenssionless_numbers
module:Added new module
mass_transfer_correlations
with:Added tests and docs for all new functions.