search

wighawag / bleeps

Bleeps, The First Truly onchain sounds
https://bleeps.art
MIT License
25 stars 5 forks source link

Failing test when using hardhat 2.11.0 #4

Open nikola-matic opened 2 years ago

nikola-matic commented 2 years ago

With the latest hardhat release 2.11.0, the following test fails

  1) BleepsFixedPriceSale
       mint:
     Error: No Contract deployed with name BleepsInitialSale
      at Object.getContract (node_modules/@nomiclabs/hardhat-ethers/src/internal/helpers.ts:447:11)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

Previous stable version of hardhat 2.10.2 works as intended.

wighawag commented 2 years ago

Thanks @nikola-matic for reporting, I ll have a look later

wighawag commented 2 years ago

Hey @nikola-matic which branch have you been testing, I added CI on main and it works : https://github.com/wighawag/bleeps/actions/runs/3010124024

nikola-matic commented 2 years ago

Heya, this was actually breaking the bleeps external tests over in https://github.com/ethereum/solidity. See bleeps.sh for how we actually run these (although looking at your README, our approach is a bit different; we also remove all *lock files as well prior to installing dependencies).

The latest hardhat release (2.11.0) actually broke most of our external tests for one reason or another.