wighawag / forge-deploy

MIT License
113 stars 10 forks source link

Issues with broadcast folder #13

Open 0xCalibur opened 1 year ago

0xCalibur commented 1 year ago

It might an harder problem to tackle but forge-deploy doesn't play well if you have files inside broadcasts/ that were deployed without forge-deploy, using barebone forge scripts.

Also, If I delete a deployment file so that it is forced re-deployed, forge-deploy sync is going to add back some of the old deployment back (if I didn't redeployed them yet).

Anyway, lots of small issues that prevents a fire-and-forget-about-it deploying experience.

My workaround for now is to rm -rf broadcast/ folder after every forge-deploy sync.

wighawag commented 1 year ago

yes, I was foreseing this kind of issues

for issue 1, I am surprised it is causing an issue as I thought forge-deploy would skip things not matching its format. I ll investigate

for issue 2, I need to add a timestamp somewhere to not resync each time

Thanks again for reporting all these issues. this helps a lot