search

wighawag / hardhat-deploy-ethers

MIT License
70 stars 25 forks source link

Fix a bug for loading artifacts in getContractAt #16

Closed maAPPsDEV closed 2 years ago

maAPPsDEV commented 2 years ago

Summary Of Changes

This PR fixes a bug for loading artifacts in getContractAt()

And:

Testing Notes

You can test new changes via script:

yarn mocha --recursive \"test/with-hardhat-deploy.ts\" --exit

Result:

Ganache spawn: 1.545s
### Started our own ganache instance with args: '["-d"]' in 1564ms ###
  hardhat-deploy plugin
    hardhat config with external artifacts
      getContractAt
        with the name and address
          ✔ Should return an instance of a contract (614ms)

### Stopped ganache instance ###

  1 passing (3s)

Deployment Notes

Closes #15

wighawag commented 2 years ago

Thanks!

maAPPsDEV commented 2 years ago

Thank you so much for the fast review, @wighawag 👍 🙌 Could you please release a tag, so that I can use it in the current project shortly? Cheers! 🥂

wighawag commented 2 years ago

forgot to mention, it is already in : 0.3.0-beta.11