search

wighawag / hardhat-deploy-ethers

MIT License
70 stars 25 forks source link

SignerWithAddress in a different path vs "@nomiclabs/hardhat-ethers" #17

Closed Jack-ZooFiLabs closed 2 years ago

Jack-ZooFiLabs commented 2 years ago

So I followed the issue https://github.com/wighawag/hardhat-deploy-ethers/issues/12 to get hardhat-deploy-ether to work by adding an alias to @nomiclab/ethers

However, looks like SignerWithAddress is not in the same path so alias doesn't work perfectly. Please fix it.

The diff I have to make:

-import { SignerWithAddress } from "@nomiclabs/hardhat-ethers/signers";
+import { SignerWithAddress } from "@nomiclabs/hardhat-ethers/dist/src/signers";
Jack-ZooFiLabs commented 2 years ago

@wighawag / @bdphilly / @feuGeneA / @TomAFrench Please take a look.

jeffreyzzzs commented 2 years ago

Encountered the same problem, is there a solution?

wighawag commented 2 years ago

@Jack-ZooFiLabs @jeffreyzzzs I published v0.3.0-beta.13 that now reuse the same compilation output settings as hardhat-ethers

Let me know if this does not work (And reopen the issue). Thanks for the reports!