Closed heri16 closed 1 year ago
hardhat-deploy-ethers would like to be an extension to hardhat-ethers but this is issue is blocking : https://github.com/nomiclabs/hardhat/issues/1040
I ll see if I can find some time soon to update hardhat-deploy-ethers
How can I help?
@heri16 if you could make a PR that incorporate the changes in @nomiclabs/hardhat-ethers that would be great.
@heri16 if you could make a PR that incorporate the changes in @nomiclabs/hardhat-ethers that would be great.
@wighawag Added PR #8
Is it accurate to say that this plugin's main goal is to extend the HardhatRuntimeEnvironment
?
ethers: {
getSignerOrNull: (address: string) => Promise<SignerWithAddress | null>;
getNamedSigners: () => Promise<Record<string, SignerWithAddress>>;
getNamedSigner: (name: string) => Promise<SignerWithAddress>;
getNamedSignerOrNull: (name: string) => Promise<SignerWithAddress | null>;
getUnnamedSigners: () => Promise<SignerWithAddress[]>;
getContract: <T extends ethers.Contract>(
name: string,
signer?: ethers.Signer | string
) => Promise<T>;
getContractOrNull: <T extends ethers.Contract>(
name: string,
signer?: ethers.Signer | string
) => Promise<T | null>;
}
And also to change hre.artifacts.readArtifact(name)
inside hre.ethers.getContractFactory()
to hre.deployments.getArtifact(name)
?
Added PRs to upstream:
hardhat-deploy-ethers@next has been released Please, try it out.
It is now an extension to hardhat-ethers so you need both
But note that that new version do not support external artifact if you were using them
SignerWithAddress._signTypedData()
is missing.See: https://github.com/nomiclabs/hardhat/blob/hardhat-ethers-v2.0.2/packages/hardhat-ethers/src/signers.ts#L40-L44
https://github.com/nomiclabs/hardhat/blame/hardhat-ethers-v2.0.2/packages/hardhat-ethers/src/signers.ts#L40-L44
@wighawag Maybe we should be using git submodules to ensure that any updates to
@nomiclabs/hardhat-ethers
is integrated seamlessly?