search

wighawag / hardhat-deploy-ethers

MIT License
70 stars 25 forks source link

Use `@nomiclabs/hardhat-ethers/signers` #8

Closed heri16 closed 3 years ago

heri16 commented 3 years ago

Use SignerWithAddress from @nomiclabs/hardhat-ethers/signers.

Fixes #7

heri16 commented 3 years ago

@wighawag This looks good to you?

I was going the git-subtree route in https://github.com/heri16/hardhat-deploy-ethers/tree/merge-nomiclabs decided against that.

heri16 commented 3 years ago

How about using aliases inside peerdeps?

https://gist.github.com/waynebloss/096168e42dbdb04b26b71c9058e25fda#tldr-this-works-for-peerdependencies-of-your-dependencies

wighawag commented 3 years ago

I created a PR that include the changes right in hardhat-deploy-ethers : https://github.com/wighawag/hardhat-deploy-ethers/pull/9

I need to do some more test though

wighawag commented 3 years ago

I decided to merge my PR, seems like it is working. Thanks for helping out.

Let me know if you have issue with latest version (that include the new SignerWithAddress type) : 0.3.0-beta.10