any special reason for using murmur-128 hash ?

wighawag / hardhat-deploy

hardhat deployment plugin

MIT License

1.2k stars 296 forks source link

any special reason for using murmur-128 hash ? #187

Open drortirosh opened 3 years ago

drortirosh commented 3 years ago

In general, I try to reduce dependencies unless they are really needed. I understand that you wanted to use a "fast non-cryptographic hash" - but murmur-128 is SLOWER than keccak256 (probably it COULD be faster, but keccak is highly optimized, and already an existing dependency)

wighawag commented 3 years ago

Hi @drortirosh yes it was the reason. I might also be able to get rid of it completely now as I think hardhat now generate a deterministic hash for the build info that I could reuse.