Closed lbeder closed 1 year ago
Hey @wighawag, could you take a look? We have been using this for over a month very successfully with many transactions in a single script
Hey @wighawag, any update on this one?
@wighawag?
Hey @wighawag, this is the very last missing piece for hardhat-deploy
to fully work with Ledger (or at least a Ledger Nano X). I haven't looked at the conflict of this branch but my guess is that it should be easy to merge. 🙏
Hey @lbeder would you mind reviewing the changes and fixing the conflict.
sorry all for not being very quick on all these PR/issues, been carried away with many other things
Hey @wighawag, done and done. Please check it out 🙏
Excelent, thanls @lbeder
published under 0.11.28
I have also encountered https://github.com/wighawag/hardhat-deploy/issues/88 where
ethers
doesn't close (or reuses) open HID connections correctly, which makes it impossible to execute the scripts using a Ledger device, resulting in a crash innode-hid
.This PR fixes this issue by keeping track of an opened
LedgerSigner
instance and closing it beforeethers
attempts to open another connection to the device.I tested this on our heavy deployment (https://github.com/bancorprotocol/contracts-v3/tree/dev/deploy), and everything works properly.