search

wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.18k stars 286 forks source link

Incorrect DiamondLoupeFacet implementation used in Diamond deployments #352

Closed ghost closed 2 years ago

ghost commented 2 years ago

Describe the bug Due to a name collision the extended artifact used for DiamondLoupeFacet in the helper source refers to the DiamondLoupeFacetWithoutSupportsInterface.sol implementation.

To Reproduce Deploy a diamond using the plugin

Expected behavior Use DiamondLoupeFacet.sol

versions

Additional context From diamond discord: @wighawag:

DiamondLoupeFacetWithoutSupportsInterface is not used indeed, it was coded to test the idea of letting user implements its own ERC165 mechanis separatly

wighawag commented 2 years ago

Oh I see, DiamondLoupeFacetWithoutSupportsInterface.sol is wrong.

So the issue you encounter is that the DiamondLoupeFacet inside DiamondLoupeFacetWithoutSupportsInterface.sol is used instead of the one in DiamondLoupeFacet.sol, right ?

ghost commented 2 years ago

Exactly!

wighawag commented 2 years ago

This is bad, I ll fix that as soon as I can, thanks for reporting!

ghost commented 2 years ago

Cheers 🙏

wighawag commented 2 years ago

Should be fixed in 0.11.12