wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.19k stars 292 forks source link

The pnpm-lock.yaml is misleading #375

Closed nhynes closed 2 years ago

nhynes commented 2 years ago

Describe the bug The pnpm-lock.yaml is not actually used any more. This is clear because this project is not buildable after pnpm install since the ethers transitive deps are imported, but not hoisted. This could be solved by "shamefully hoisting" deps by setting the npmrc config, but that largely defeats the point of pnpm.

To Reproduce

  1. clone the repo
  2. pnpm install --frozen-lockfile
  3. pnpm build
  4. observe errors about missing dependencies

Expected behavior pnpm install && pnpm build to work, or for there not to be a pnpm-lock.yaml

versions