wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.19k stars 292 forks source link

hardhat-deploy-ethers causes unexpected warnings. #400

Closed neulad closed 1 year ago

neulad commented 1 year ago

Describe the bug With the current version of hardhat (2.12.4) hardhat-ethers is loaded from hardhat-toolbox package. So as the best way to replace default hardhat-ethers package with npm:hardhat-deploy-ethers I used custom overrides in package.json file, which you can see below

  "overrides": {
    "@nomicfoundation/hardhat-toolbox": {
      "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers"
    }
  }

It worked perfectly well, however it stopped working few days ago and started to throw this error instead:


image


I decided to just install hardhat-deploy-ethers using npm install --save-dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers command. This trick worked, however I get huge bunch of warnings that leaves me in concern


image


The whole idea of adding overrides to package.json was to avoid this kind of errors and build more clear peer dependencies.

What is the solution for this issue, with comparator, or maybe I mayble I install hardhat-deploy-ethers in the wrong way?

To Reproduce Steps to reproduce the behavior:

  1. execute npm install --save-dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers
  2. See error

versions

neulad commented 1 year ago

If anybody gets this error, it's because 9.2.0 version of npm doesn't accept npm:hardhat-deploy-ethers. Downgrade it to 8.9.0 and it will work. Reference: https://github.com/npm/cli/issues/5955