wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.17k stars 283 forks source link

Docs for deterministicDeployment outdated regarding "Celo or Avalanche" #401

Open bergben opened 1 year ago

bergben commented 1 year ago

In the Readme explanation for deterministicDeployment is stated

One use case for this is the deterministic deployment on networks that required replay protection (such as Celo or Avalanche) See https://github.com/wighawag/hardhat-deploy#4-deterministicdeployment-ability-to-specify-a-deployment-factory

This is outdated I believe. For Celo this should have changed: https://github.com/celo-org/celo-blockchain/issues/1734 For Avalanche in the release notes if you search for "Replay" you will find that there was an option to bypass enforcement: image https://docs.avax.network/apis/avalanchego/avalanchego-release-notes

I had no issues at all deploying to Avalanche directly and got the expected addresses same as on other networks. I don't know which other networks could be used as listed examples, but as far as I know, Celo and Avalanche are now incorrect.