search

wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.17k stars 283 forks source link

Maximum call stack size exceeded #459

Closed migoldfinger closed 1 year ago

migoldfinger commented 1 year ago

Describe the bug While setting up a huge repository with deployment I ran into this error

RangeError: Maximum call stack size exceeded
    at Array.values (<anonymous>)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1164:45)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)
    at recurseDependencies (E:\Workspaces\ExumaGroup\dfx-contracts\node_modules\hardhat-deploy\src\DeploymentsManager.ts:1168:15)

To Reproduce

  1. Make a huge deployment with lots of dependencies
  2. See error

Expected behavior As long as I as a human can handle all dependencies so should a program.

versions Version of Hardhat 2.15.0 Version Hardhat-deploy 0.11.30 Version of nodejs 18.16.0

Additional context Repo: https://github.com/DFX-Protocol/dfx-contracts/tree/stackError and I am not finished yet.....

migoldfinger commented 1 year ago

I had a circle reference though copy and paste