Non-Deterministic Diamond Deploy

wighawag / hardhat-deploy

hardhat deployment plugin

MIT License

1.17k stars 283 forks source link

Non-Deterministic Diamond Deploy #465

Open hickscorp opened 1 year ago

hickscorp commented 1 year ago

It seems to us that the deterministic / factory deployer pattern is overhead for some of our Diamond use cases. However, it seems impossible to utilize deployments.diamond.deploy without it. Is there a way?

wighawag commented 1 year ago

Could you elaborate ?

hickscorp commented 1 year ago

Hi @wighawag , sure:

Right now, there doesn't seem to be a way to not use deterministic deployments for Diamond stuff. I've had a look at the DeploymentManager.ts file and the deterministicDeployment option is hardcoded and set to true most of the time for diamond.deploy() with no possible override.
Default facets are added with the deterministic option set to true, also.

It would be nice to have options to override this behaviour, and "opt-out" of the deterministic stuff.