wighawag / hardhat-deploy

hardhat deployment plugin
MIT License
1.17k stars 283 forks source link

Upgrading Diamond from a MultiSig wallet #498

Open Jcalcaldev opened 7 months ago

Jcalcaldev commented 7 months ago

I'm having some issues trying to change an existing diamond's owner to a multisig and then upgrading it through hardhat deploy.

I'm using catchUnknownSigner to get the deployment transaction's raw data and execute it in the multisig (Gnosis) transaction builder.

Using this method, some deployment files are generated, but not the most important one (Game.json in my case), which contains these properties:

These files are generated when executing the deployment script, so once the transaction is executed on Gnosis, commiting the generated files should be fine, but some files are missing as mentioned.

Also, executing the script but not the deployment transaction on Gnosis still appears to create lone facets with the new functionality, but not connected to the main diamond contract.

Is there a verified method to do this correctly? Any help is really appreciated!

maikelordaz commented 5 months ago

@Jcalcaldev Have you found a way for this? What I'm doing to get the ABI is deploying on localhost, but ould like to have the correct abi for the proxy when I deploy on mainnet to the multisig