search

wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net
https://wigle.net
BSD 3-Clause "New" or "Revised" License
657 stars 204 forks source link

ENH: Dashboard TimeUnit based timeString() #537

Closed Krzysztofz01 closed 1 year ago

Krzysztofz01 commented 1 year ago

This small pull request contains one of the changes that appeared in a different closed pull request. The timeString() method used for formatting the scan related time duration has been refactored in such a way that it uses TimeUnit and that the formatted string has an explicit locale (good practices).

rksh commented 1 year ago

Thank you for making the project better!

rksh commented 1 year ago

We had to replace this because each field (hours/minutes/seconds) was displaying the totality of duration expressed in its units - 2h, 43m, 12s -> "2:163:9792"

Krzysztofz01 commented 1 year ago

We had to replace this because each field (hours/minutes/seconds) was displaying the totality of duration expressed in its units - 2h, 43m, 12s -> "2:163:9792"

Fixed in #543 😄