wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net
https://wigle.net
BSD 3-Clause "New" or "Revised" License
652 stars 201 forks source link

[ENH] Upload status <> human readable #564

Closed rksh closed 1 year ago

rksh commented 1 year ago

taking some feedback from previous code review, only to find a bug that needed fixing

rksh commented 1 year ago

we could move the IDs of the strings in there, but we'd still need a way to populate the translated strings outside the model object (otherwise we're passing Context into either the constructor or the getter to get the results in the right language for the users). Felt like weird trade-off, but I could be convinced to add the R.strings. values in as a second element to the Enum members if you think it's worthwhile/

bobzilladev commented 1 year ago

blah, yeah that's pry too weird a task for the enum to be taking on.