[BUG] Inconsistent page loading on rankings activity

wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net

https://wigle.net

BSD 3-Clause "New" or "Revised" License

652 stars 201 forks source link

[BUG] Inconsistent page loading on rankings activity #582

Closed rksh closed 1 year ago

rksh commented 1 year ago

Based on this report from the forums, it seems likely there's an error in the pagination logic. Seeking additional testing and answers to these questions:

does this happen consistently on load, or only after scrolling/loading more?
if you scroll to the top and swipe down to refresh, does it that fix/change things?
What's displayed when you first launch the activity?
when you re-start the activity (go back to the main screen, then return), does that fix or change things?

rksh commented 1 year ago

fix in https://github.com/wiglenet/wigle-wifi-wardriving/pull/583

rksh commented 1 year ago

requesting retest with 2.72

hsiboy commented 1 year ago

I'm running version v2.72 on android 13

does this happen consistently on load, or only after scrolling/loading more? Consistently, every time.
if you scroll to the top and swipe down to refresh, does it that fix/change things? No, the problem persists.
What's displayed when you first launch the activity? My current user ranking is 3223, if I select the rankings page, I'm given a view between 123 and 132 with 127 in the middle of the page.
when you re-start the activity (go back to the main screen, then return), does that fix or change things? No, no change.

rksh commented 1 year ago

still broken in 2.73.

rksh commented 1 year ago

finally fixed, see release 2.74 for fix (and attached PR above for my dumb mistake.)

hsiboy commented 1 year ago

Confirmed fixed 👌

Thank you.

rksh commented 1 year ago

it was a dumb mistake on my part - thanks for the help in catching it!