[ENH] Search enhancement

wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net

https://wigle.net

BSD 3-Clause "New" or "Revised" License

649 stars 199 forks source link

[ENH] Search enhancement #638

Closed rksh closed 8 months ago

rksh commented 9 months ago

This is basically a full rewrite. A number of TODOs in-line, but also some questions:

is it worth keeping the (low-featured) search in the "Database" activity as well as the more-fully-featured Search activity proper? There's real complexity here as a result of keeping both working.
Is the movable map view for search bounds too confusing
Is the overlap on the map view too confusing.

Confident that this is "better," but probably needs further refinement before it's "good"

bobzilladev commented 9 months ago

Hot takes without loading it:

is it worth keeping the (low-featured) search in the "Database" activity as well as the more-fully-featured Search activity proper? There's real complexity here as a result of keeping both working.

Can pry get rid of the DB one, the results are the same anyway.

Is the movable map view for search bounds too confusing

Will want to make sure we can still get a list result from anywhere, not bound by the geo

rksh commented 8 months ago

to me, argues for leaving Database Activity "Search" in place, no geo bound.

bobzilladev commented 8 months ago

Maybe keeping it is good. Can the backend of both views be consolidated more to make life easier?

bobzilladev commented 8 months ago

Feedback after finally getting android studio to load without locking up, and installing on a device:

On DB and Search view, the two dropdowns just have All and ALL, assume we'll have some kind of label on there for what is being chosen, probably this is one of the i18n todo's already
The DB with no results shows the [device] - X - [wigle] icon, maybe doesn't make sense here. Same with Search view on local database mode.
The Search view in search-wigle mode shows a blank screen with no results, probably could use above graphic.
Query on Search view, then go back to DB view, I think the DB view is carrying over the geo bounds somehow, a search that should work no longer does if I move the Search view away from it. Maybe a pref is carrying over and not being reset?
If you go to DB view then back to Search view the search area is blank, pry carrying over the opposite way

Overall I like the direction of the change, will be awesome to ship after some polish.

rksh commented 8 months ago

I've updated to leave the screens consistently blank when there's no error but no results now. We could add a mode to indicate "no results" graphically in the ProgressThrobberActivity but that would be cross-cutting, and I don't really have an idea for what that should look like (yet). (breaking feedback into issue-sized chunks)

rksh commented 8 months ago

I'd copied some common UIs styles to try and get away with "All" - "ALL" inviting users to click to discover the filters... maybe too opaque

rksh commented 8 months ago

I've reset the geobounds to blank for the Database activity - that's a great catch. The geobounds start blank on the Search by default until you touch the map... does that violate least surprise? Should I clear those each time on re-calling the search UI?

bobzilladev commented 8 months ago

The geobounds start blank on the Search by default until you touch the map... does that violate least surprise?

Might be nice to keep this way so you are more likely to get results on your first search, and then can drill down with geo bound on from there. Don't know if users will get confused on that. But pry will get confused if they search for something they know they have and don't get anything back, too. 🤔