search

wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net
https://wigle.net
BSD 3-Clause "New" or "Revised" License
669 stars 206 forks source link

Confusing loading state in Battery Saver #699

Open graciouselectric opened 5 months ago

graciouselectric commented 5 months ago

Dear developer,

I noticed that when I enable Battery Saver on Android 8.1, the indeterminate ProgressBars in the app are not properly shown. This is a known problem in Android API level <28, see e.g. this StackOverflow question. Battery Saver disables animations, also on progress bars on these versions. This is quite confusing because the loading state is not properly represented. It is fixed in later Android versions, where progress bars do appear and animate.

Looking at the code, indeterminate progress bars are created here:

className='net.wigle.wigleandroid.background.AbstractBackgroundTask', lineNumber=169
className='net.wigle.wigleandroid.ProgressPanel', lineNumber=30

To fix this issue, one can check ValueAnimator.areAnimatorsEnabled() and provide a different UI element, such as a text label, when animations are disabled.

rksh commented 4 months ago

Running the application in battery saver mode will have extensive negative impacts on numerous other aspects of application performance and effectiveness.