wiglenet / wigle-wifi-wardriving

Nethugging client for Android, from wigle.net
https://wigle.net
BSD 3-Clause "New" or "Revised" License
691 stars 210 forks source link

Light mode appearance: icons, text colors #712

Open Artoria2e5 opened 1 month ago

Artoria2e5 commented 1 month ago

We got the much-needed light mode in #476, but I would think that most people agree that something looks off about it. So what's really wrong with it?

Compare: image temp

Icons

The icons on top look like thin skeletons in light mode. We need to provide inverted versions of the icons, so they look about as thick as they do in dark mode.

Text color

Text appears in a variety of colors in dark mode; more important text is given a brighter color, so they have higher contrast against the background. Light mode does not have this kind of color-importance correspondance:

rksh commented 1 month ago

Pull requests are very welcome!

rksh commented 1 week ago

the menu icons work that way because the R.attr.colorControlNormal tint doesn't appear to get applied to them - could be because they from the android.R.drawable.ic_menu... family

rksh commented 1 week ago

ah, yes, they're image chains.