search

wiheto / netplotbrain

A package to create simple 3D network visualizations on a brain.
Apache License 2.0
67 stars 7 forks source link

BUG/ENH: consistent input for view and hemisphere #44

Closed wiheto closed 2 years ago

wiheto commented 2 years ago

For the user's sake we should have consistent input for view and hemisphere.

Currently working on #31 and noticed some weirdness in user interface. For a 2x2 view plotting L/R hemispheres form L/R views.

At the moment: 

view = [['L' 'R'], ['R', 'L']]
hemisphere = [['L', 'R'], ['L', 'R']]

and 

view = [['LR'], ['RL']]
hemisphere = [['LR'], ['LR']]

will both lead to an error

At present what is needed to get the above to work is:

view = [['LR'], ['RL']]
hemisphere = [['L', 'R'], ['L', 'R']]

Desired outcome:

Both the invalid examples should work.

Function that needs modifying:

_get_frame_input

Difficulty:

moderate (cause modifications to _get_frame_input could change other functions)

wiheto commented 2 years ago

Fixed