Update plot_cm.py - Githubissues

wiheto / netplotbrain

A package to create simple 3D network visualizations on a brain.

Apache License 2.0

67 stars 7 forks source link

Open seblome opened 1 month ago

seblome commented 1 month ago

Added network-specific coloring of the CM border when specifying cm_bordercolor = 'networks'.
Removed the possibility for alpha to vary between different networks when drawing boundaries.
Added a new kwarg "cm_boundaryalpha" that adjusts alpha of the CM boundary.

wiheto commented 1 month ago

Great!

Some comments:

[ ] could you add documentation about the new cm_bordercolor option and a new cm_boundaryalpha to docs/api.md. Should be straight forward - but if it is unclear let me know.
[ ] could you add a default value (1, I guess) of cm_boundaryalpha to netplotbrain/profiles/default.json

After that I will update the tests and add a test for this code as well.