Closed jolespin closed 4 years ago
All looks good. I'll merge this soon cause there is a couple of things I need to add regarding documentation and Travis CI installing all the neuropackages.
Thanks for this!
Awesome! Thanks for proceeding with this. I'll need to look at Travis CI documentation as I'm quite new to PR requests on GitHub. This is one of my firsts.
I’ll do the next step very very soon and this will be accepted. You don’t need to do anything more here at all. But to explain what I need to do (if you are curious): travis uses the requirements.txt to install the software and run the tests. So the settings file (.travis.cli) file needs a to be told to install the additional requirements, otherwise tests will fail cause the software for the neuro tests is missing. It’s a very small thing to fix, but that’s basically it.
There’s a few other things I want to check as well, such as the dockerfile. All minor things.
Congratulations on one of your first PRs! Happy that you contributed to teneto.
29 maj 2020 kl. 16:19 skrev Josh L. Espinoza notifications@github.com:
Awesome! Thanks for proceeding with this. I'll need to look at Travis CI documentation as I'm quite new to PR requests on GitHub. This is one of my firsts.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Ok, LGTM. Thanks for contributing! One thing I need to fix soon is a way to add all contributors to the zenodo DOI. I'll send you a message sometime in the near future about this.
I'm sorry but all these changes have been removed the neuro requirements are going to be kept for some time. As it stood, the PR did not import the packages correctly into globals and all tests using these packages were broken. If you can fix this, I'll be happy to include it, but until then, I'm removing the functionality and the three neuropackages will remain in the requirements.
I forked
https://github.com/wiheto/teneto
and added that to my GitHub. After that I adjusted files that loadedbids
,nilearn
, andtemplateflow
.There were more files that I needed to adjust than ones in
utils
as shown below. Any function using one of those packages I had to addcheck_packages
decorator or else there will be an import error.I also adjusted the
setup.py
:and
requirements.txt