search

wiiznokes / fan-control

Control your fans with different behaviors
GNU General Public License v3.0
131 stars 10 forks source link

Input box missing - description string doesn't wrap #152

Open Jopp-gh opened 1 month ago

Jopp-gh commented 1 month ago

Bug Description

the max width of widgets is way too narrow, please see the linear widget (2nd column) in my attachment

German uses pretty long composite names, so I can't even set a value for minimum speed in "linear" curves, because the input box is on the outside of the widget. Also the other input boxes in the same "linear" curves widget are too narrow, barely readable.

FAN-c

Expected Result

To be able to insert all possible values

Steps to Reproduce

Add a linear curve and check the min speed value (German env)

Possible Solutions

I suggest to enlarge the width of widgets and wrap long strings so they break and continue on the next line.

Operating system

Linux Mint Virginia

fan-control version

2024.6

wiiznokes commented 1 month ago

I will look into it. In the meantime, you can use the config file

wiiznokes commented 1 month ago

I can't fix it currently, due to limitation in libcosmic. But the fix i was thinking was to use ..., witch isn't a good solution for a static translation of the app. I would suggest to change the German translation to something shorter, or don't translate this fields.

For example, in French, even if it's not a perfect solution, i didn't translate it because i think it's clearer having

min_temp = min temp
min_speed = min speed

instead of

min_temp = temp min
min_speed = vitesse min

(to keep the min prefix)

Jopp-gh commented 1 month ago

Thanks for your quick answer

Fan control doesn't have a switch to change to another language. Did you mean, I can change language in some configuration file?

Yeah, to truncate long strings is a quick solution. Also, I could provide a new and shorter German localization of Fan Control's strings, if you're interested.

On the long run however, I'd like to see the width of widgets slightly increased.

wiiznokes commented 1 month ago

Fan control doesn't have a switch to change to another language. Did you mean, I can change language in some configuration file?

You can either submit a pr with new german translation (https://github.com/wiiznokes/fan-control/blob/master/CONTRIBUTING.md) or use flatseal to set this env variable LANG=us. This will make fan-control use english translations

On the long run however, I'd like to see the width of widgets slightly increased.

I will consider it

Jopp-gh commented 1 month ago

use flatseal to set this env variable LANG=us.

Great

On the long run however, I'd like to see the width of widgets slightly increased.

I will consider it

Thanks.

Here a quick mockup how I would change widget width: FanC-mockup