search

wijnandtop / home_assistant_gardena

Custom component to support Gardena smart devices
31 stars 7 forks source link

Files moved/renamed/adapted to meet Hass.io 0.88 migration requirements. #6

Closed Jpsy closed 5 years ago

Jpsy commented 5 years ago

resolves #5

Jpsy commented 5 years ago

I am not sure about the best place for the README.md. Putting it into root will create future collisions with other custom components. Putting it into gardena/ (as I have done now) will not show it here on Github, unless you navigate down to that folder. Maybe the best way would be to completely remove the gardena/ path from the repo (placing all files in root) and add instructions to deploy the content of the repo into folder custom_components/gardena/.

wijnandtop commented 5 years ago

Hey Jpsy, thanks for your contribution! 👍

I agree with your proposal to just remove the gardena path and move the files in the root (and update the docs).

On the other hand I like to make the component compatible with the https://github.com/custom-components/custom_updater component. Not sure if this has specific requirements.