search

wikilinks / neleval

Entity disambiguation evaluation and error analysis tool
Apache License 2.0
116 stars 23 forks source link

Add data validation (fixes #6) #10

Closed jnothman closed 9 years ago

jnothman commented 9 years ago

Fixes #6. This raises an error upon duplicate mentions. It also warns on nested or crossing mentions.

This is somewhat flexible in its handling, but no interface is provided to affect that setting.

Should we ignore crossing mentions by default so that it's silent when processing TAC?

benhachey commented 9 years ago

Ignore crossing mentions by default, or nested mentions?

On Mon, Nov 10, 2014 at 12:23 AM, jnothman notifications@github.com wrote:

This raises an error upon duplicate mentions. It also warns on nested or crossing mentions.

This is somewhat flexible in its handling, but no interface is provided to affect that setting.

Should we ignore crossing mentions by default so that it's silent when

processing TAC?

You can merge this Pull Request by running

git pull https://github.com/wikilinks/neleval fix6

Or view, comment on, or merge it at:

https://github.com/wikilinks/neleval/pull/10 Commit Summary

  • Add data validation

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/wikilinks/neleval/pull/10.

Dr Ben Hachey benhachey.info +61 416 550 174

jnothman commented 9 years ago

Nested ;)

benhachey commented 9 years ago

OK. Agreed it should be silent for annotations that are valid according to the TAC spec. But good to have a flag to request warnings for nested mentions.

On Mon, Nov 10, 2014 at 10:46 AM, jnothman notifications@github.com wrote:

Nested ;)

— Reply to this email directly or view it on GitHub https://github.com/wikilinks/neleval/pull/10#issuecomment-62325995.

Dr Ben Hachey benhachey.info +61 416 550 174

jnothman commented 9 years ago

Merging.