search

wikilinks / neleval

Entity disambiguation evaluation and error analysis tool
Apache License 2.0
116 stars 23 forks source link

grep -P no longer works on MacOS X #4

Closed slbayer closed 10 years ago

slbayer commented 10 years ago

Not sure if you care, but the run_tac14_report.sh script fails on MacOS X 10.9 because the -P option has been removed from BSD grep. It was there in 10.8. Recommended solution is to install GNU grep (not a practical requirement) or replace with awk or perl:

http://stackoverflow.com/questions/16658333/grep-p-no-longer-works-how-can-i-rewrite-my-searches

jnothman commented 10 years ago

We care. -P is completely unnecessary there. Will fix!

benhachey commented 10 years ago

Good catch. Thanks! On Sep 18, 2014 8:36 AM, "jnothman" notifications@github.com wrote:

We care. -P is completely unnecessary there. Will fix!

— Reply to this email directly or view it on GitHub https://github.com/wikilinks/neleval/issues/4#issuecomment-55971667.

benhachey commented 10 years ago

Fixed in 0dd24bc.