rewriteAnchors doesn't check if the <a> tag had an 'href'

[edg2s]

OOUI buttons, such as those used in VE, use <a> tags without an href.

This script appears to rewrite the empty href back to the tag as <a href="undefined">, which means clicking on any tool in VE navigates you off the page.

Reported here: https://phabricator.wikimedia.org/T352501

[diskdance]

@edg2s Both from TypeScript or my own testing shows that for an without href accessing href returns an empty string.

The undefined is caused by Jon (WMF)'s hotfix which causes rewriteLink to return undefined when an exception is thrown.

Sorry about that. Do you need help applying the fixes to this repo?

cc @jdlrobson

[diskdance]

I have asked admins to apply hot fixes for now. I'm currently working on various improvements on this project and I hope to deploy all the improvements to the wiki in the near future. Thanks!

[jdlrobson]

Sorry for my failed fix! I can confirm the error is no longer appearing in production.

Thanks @esanders for patching the production version.