search

wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
37 stars 80 forks source link

Should not duplicate existing wikiproject tags on talk page #148

Closed siddharthvp closed 3 years ago

siddharthvp commented 3 years ago

See this edit, in which the Biography project tag that already existed on the talk page was duplicated.

Suggested fix: parse the talk page for existing wikiproject tags[1], show them using the jquery.chosen select menu allowing the reviewer to remove existing ones, add new ones, etc.

This task is also a blocker for the deployment of AFC-submit-wizard discussed here.

[1] some code for this exists here: function extractWikiProjectTagsFromText, which doesn't work 100% of the time but good enough I think.

primefac commented 3 years ago

Wasn't this already fixed?

siddharthvp commented 3 years ago

Let me see. Last I checked may have been in October ...

siddharthvp commented 3 years ago

https://github.com/WPAFC/afch-rewrite/commit/4ad387d9e7173137e8db6b3bbbec9df631069198 suggests yes, thanks @enterprisey!