wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
37 stars 80 forks source link

Remove manual dependency imports #149

Closed enterprisey closed 3 years ago

enterprisey commented 3 years ago

In non-beta mode, we use mw.loader.using to get all the ResourceLoader dependencies. This is wasteful, since ResourceLoader is instructed (using Gadgets-definition) to get them anyway. We should remove the using() call, but there are two users on the English Wikipedia who import the script directly, bypassing ResourceLoader. I have asked them to change over, and in a week I'll do so anyway (as it will not result in any observable difference whatsoever). I am thus filing this issue as a reminder.

Note! I must move the whole using() call to load() in core.js after I remove it, to preserve functionality when beta is true.