wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
37 stars 80 forks source link

Order of comments that don't use {{AFC comment}} gets scrambled #168

Open NovemLinguae opened 3 years ago

NovemLinguae commented 3 years ago

Example: https://en.wikipedia.org/w/index.php?title=Draft:Center_for_Rural_Development&oldid=1033372395

Note the 4 {{AFC comments}} generated by AFCH, and the two non {{AFC comments}} left by the IP. They were originally indented replies to the comments above, under specific comments. AFCH scrambled them, moving them to the bottom. It'd probably be better if AFCH left the order alone.

image

Compare to the original IP's comment placement: https://en.wikipedia.org/w/index.php?title=Draft:Center_for_Rural_Development&oldid=1033361141

image

primefac commented 3 years ago

While this can certainly be seen as an issue, from a BAG perspective I would see this as a CONTEXT issue; how does the bot know what's a reply to a comment, and what's just random text thrown in? I've seen {{AfC comment}} templates used at the very bottom (below the new {{submit}} tag), and if some sort of "keep everything between the AfC comments static" fix were put into place, that draft would not be editable since the last AfC comment would mess everything up.

I could be wrong, but I don't see as how there is a good way to fix this issue, other than manually converting the indented comments either into AfC comments of their own or merging them into the existing AfC comments.