wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
37 stars 80 forks source link

Allow adding/editing shortdesc while accepting #190

Closed siddharthvp closed 2 years ago

siddharthvp commented 3 years ago

At the moment the acceptance form does ask for "Description of the subject" for bios, but the value entered seems to just go into the void. I'm assuming this is a remnant from when persondata used to be supported?

In any case, short description support would be good to have. From what I've seen, most folks tend to add appropriate shortdescs while submitting, but sometimes not. If it's shown while accepting, the reviewer could change it to something suitable.

primefac commented 3 years ago

There's been a push to update the "accept" values the reviewer needs to input, but I never thought to just change that description to a straight-up {{short description}}. Genius. While we're on the subject, though, it might be worth checking out all of the fields the "accept" menu gives, and remove or re-target anything that isn't useful.

primefac commented 3 years ago

image The above is for an accepted biography of a dead person. If "living" is selected the death info doesn't show, and if the biography box isn't checked then none of the subsequent info shows.

siddharthvp commented 3 years ago

Looking at the source code, the script doesn't seem to use the values entered in "Description of the subject", "Month and day of birth", "Place of birth", "Month and day of death", "Place of death" anywhere at all – they're simply discarded!

siddharthvp commented 3 years ago

Opened #191 to remove those.

enterprisey commented 2 years ago

Indeed, the values don't seem to be used. That's remarkable.

For posterity, they used to be used for Persondata, but I removed that use in 9632e4fdd701178968867e9936e1d7eda77b1d8a and didn't think to remove them from the UI. That's a lot of wasted time spent filling those out... ah, better late than never.