search

wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
36 stars 80 forks source link

remove version number #270

Closed NovemLinguae closed 11 months ago

NovemLinguae commented 1 year ago

image

Just one more thing for developers to forget to update. Any objections to removing the version number from the codebase, edit summaries, etc?

primefac commented 1 year ago

Fine by me.

NovemLinguae commented 1 year ago

Looks like https://github.com/wikimedia-gadgets/afch-rewrite/blob/master/scripts/release.py does a bunch of version stuff automatically, such as bumping the version variable. Supposedly.

"0.9.1 Imperial Ibex (05 December 2018)", the current version, says December 2018, but I know we've deployed a couple times since then.

Also git + GitHub version tagging is not occurring consistently. Says we're still on 0.9 from Nov 2014.

image

@enterprisey, when you deploy, do you use the release.py script? Maybe it's broken in regards to bumping the version number.

siddharthvp commented 1 year ago

Support. Version numbers in edit summary only tends to confuse folks. I've seen multiple times people misunderstanding 0.9.1 to some kind of rating given to the draft.

Note the release.py script doesn't do any on-wiki deployment - it's just for updating the version number, so unused since 2018. GitHub UI would only show releases created via GitHub's releases tab.

KylieTastic commented 1 year ago

Yup, never liked having that in the edit summaries

enterprisey commented 1 year ago

haha, works for me. guess we're CI/CD now. the version numbers were definitely from before my time. I just use deploy.py (although I've been intending to rewrite that), no release.py.