search

wikimedia-gadgets / afc-helper

A tool for reviewing Articles for Creation submissions on the English Wikipedia
https://en.wikipedia.org/wiki/Wikipedia:AFCH
GNU General Public License v3.0
35 stars 77 forks source link

deploy script adding strange unicode character #302

Closed NovemLinguae closed 10 months ago

NovemLinguae commented 11 months ago

https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-afchelper.js/tpl-submissions.js&diff=prev&oldid=1184646437

This  character is not in the repo, and should not be getting written when we run the deploy script. Bug in the deploy script?

@enterprisey thinks it may be because I am using Windows.

image

NovemLinguae commented 11 months ago

An error I get in the deploy console is the following. Maybe it's related?

Building afch-rewrite using `grunt build`...
OSError encountered. Attempting to use os.system...

image

sohomdatta1 commented 11 months ago

It definitely could be, the corrupt sequence ends with 0a which is known to be one of those sequences that has caused issues with Linux and Windows compatibility :( Screenshot from 2023-11-11 21-46-51