search

wikimedia-gadgets / shortdesc-helper

Gadget on the English Wikipedia.
8 stars 4 forks source link

fix missing styling when using skins vector 2010 and monobook #10

Closed NovemLinguae closed 11 months ago

NovemLinguae commented 1 year ago

Fix #7

NovemLinguae commented 1 year ago

Requested hotfix deployment of this patch at https://en.wikipedia.org/wiki/Wikipedia_talk:Shortdesc_helper#Hotfix_for_vector_and_monobook_size_bug

It can still go through normal code review here though.

mmiyer commented 1 year ago

Feel free to make whatever hotfix changes needed. I’ll probably try to review it when I’m back from vacation and see if I can fix it properly with add subtitle etc. (or you can too - I’m not too particular about needing things code reviewed etc.)

On Sat, Jun 17, 2023 at 6:40 AM NovemLinguae @.***> wrote:

Requested hotfix deployment of this patch at https://en.wikipedia.org/wiki/Wikipedia_talk:Shortdesc_helper#Hotfix_for_vector_and_monobook_size_bug

It can still go through normal code review here though.

— Reply to this email directly, view it on GitHub https://github.com/wikimedia-gadgets/shortdesc-helper/pull/10#issuecomment-1595620581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2KFWNMSF3EMQ4HXQHDWZTXLUYKDANCNFSM6AAAAAAZJ7QSXM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

NovemLinguae commented 11 months ago

This PR appears to have been declined in https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-Shortdesc-helper.css&diff=prev&oldid=1160886559