search

wikimedia-gadgets / shortdesc-helper

Gadget on the English Wikipedia.
8 stars 4 forks source link

shortdesc css causes message boxes on deleted pages to overlap #14

Open NovemLinguae opened 1 year ago

NovemLinguae commented 1 year ago

Steps to reproduce:

What happens?

What should happen instead?

Root cause

NovemLinguae commented 4 months ago
image

The oldest commit I can find with the above code is https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-Shortdesc-helper-pagestyles-vector.css&oldid=881707781, which doesn't give any hint as to what this code is used for.

What would it break if we deleted it? The positioning of the shortdesc helper gadget on mainspace pages with no text?

Can we change it to target shortdesc helper instead of whatever it's targeting now?

mmiyer commented 4 months ago

I think the page layout has changed - this is meant to remove the spacing that was created for the shortdesc helper since it is not needed on a deleted article (i.e. it should apply to mw-content-text now).

On Thu, Apr 11, 2024 at 7:41 PM NovemLinguae @.***> wrote:

image.png (view on web) https://github.com/wikimedia-gadgets/shortdesc-helper/assets/79697282/80796823-6529-4227-94c0-79cca4fac504

The oldest commit I can find with the above code is https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-Shortdesc-helper-pagestyles-vector.css&oldid=881707781, which doesn't give any hint as to what this code is used for.

What would it break if we deleted it? The positioning of the shortdesc helper gadget on mainspace pages with no text?

— Reply to this email directly, view it on GitHub https://github.com/wikimedia-gadgets/shortdesc-helper/issues/14#issuecomment-2050722368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2KFWNBV4JULKLSDX56SEDY44NQ7AVCNFSM6AAAAAA2JX7M36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQG4ZDEMZWHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>